瀏覽代碼

i965: Assign instead of compare inside assert

This is from a Coverity defect report.

src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp
  1314  void
  1315  vec4_visitor::emit_block_move(dst_reg *dst, src_reg *src,
  1316                                const struct glsl_type *type, bool
predicated)
...
  1351     /* Do we need to worry about swizzling a swizzle? */
->1352     assert(src->swizzle = BRW_SWIZZLE_NOOP);
  1353     src->swizzle = swizzle_for_size(type->vector_elements);

Reported-by: Vinson Lee <vlee@vmware.com>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=40158
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
tags/mesa-8.0-rc1
Chris Wilson 14 年之前
父節點
當前提交
ebca47af85
共有 1 個文件被更改,包括 1 次插入1 次删除
  1. 1
    1
      src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp

+ 1
- 1
src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp 查看文件

@@ -1472,7 +1472,7 @@ vec4_visitor::emit_block_move(dst_reg *dst, src_reg *src,
dst->writemask = (1 << type->vector_elements) - 1;

/* Do we need to worry about swizzling a swizzle? */
assert(src->swizzle = BRW_SWIZZLE_NOOP);
assert(src->swizzle == BRW_SWIZZLE_NOOP);
src->swizzle = swizzle_for_size(type->vector_elements);

vec4_instruction *inst = emit(MOV(*dst, *src));

Loading…
取消
儲存