Browse Source
build: make passing an incorrect pointer type a hard error
More or less any of this issue pointed out by the compiler is
a coding error. Make sure we flag it and bail loudly.
v2: - apply the change to autotools and scons as well (Emil)
- C++ doesn't need this, it's already an error and the flag
doesn't exist (Gert)
v3: - drop scons, flags are not checked so until someone adds that
functionality we can't have this.
Signed-off-by: Eric Engestrom <eric.engestrom@intel.com>
Reviewed-by: Dylan Baker <dylan@pnwbakers.com> # v1
Reviewed-by: Emil Velikov <emil.velikov@collabora.com> # v1
[Emil: apply the same change to autotools and scons]
Signed-off-by: Emil Velikov <emil.velikov@collabora.com>
Reviewed-by: Eric Anholt <eric@anholt.net>
tags/19.1-branchpoint
Eric Engestrom
6 years ago
3 changed files with 3 additions and 0 deletions
+ 1
- 0
Android.common.mk
View File
| MESA_VERSION := $(shell cat $(MESA_TOP)/VERSION) | MESA_VERSION := $(shell cat $(MESA_TOP)/VERSION) | ||||
| LOCAL_CFLAGS += \ | LOCAL_CFLAGS += \ | ||||
| -Wno-error \ | -Wno-error \ | ||||
| -Werror=incompatible-pointer-types | |||||
| -Wno-unused-parameter \ | -Wno-unused-parameter \ | ||||
| -Wno-pointer-arith \ | -Wno-pointer-arith \ | ||||
| -Wno-missing-field-initializers \ | -Wno-missing-field-initializers \ |
+ 1
- 0
configure.ac
View File
| AX_CHECK_COMPILE_FLAG([-Wall], [CFLAGS="$CFLAGS -Wall"]) | AX_CHECK_COMPILE_FLAG([-Wall], [CFLAGS="$CFLAGS -Wall"]) | ||||
| AX_CHECK_COMPILE_FLAG([-Werror=implicit-function-declaration], [CFLAGS="$CFLAGS -Werror=implicit-function-declaration"]) | AX_CHECK_COMPILE_FLAG([-Werror=implicit-function-declaration], [CFLAGS="$CFLAGS -Werror=implicit-function-declaration"]) | ||||
| AX_CHECK_COMPILE_FLAG([-Werror=missing-prototypes], [CFLAGS="$CFLAGS -Werror=missing-prototypes"]) | AX_CHECK_COMPILE_FLAG([-Werror=missing-prototypes], [CFLAGS="$CFLAGS -Werror=missing-prototypes"]) | ||||
| AX_CHECK_COMPILE_FLAG([-Werror=incompatible-pointer-types], [CFLAGS="$CFLAGS -Werror=incompatible-pointer-types"]) | |||||
| AX_CHECK_COMPILE_FLAG([-Wmissing-prototypes], [CFLAGS="$CFLAGS -Wmissing-prototypes"]) | AX_CHECK_COMPILE_FLAG([-Wmissing-prototypes], [CFLAGS="$CFLAGS -Wmissing-prototypes"]) | ||||
| dnl Dylan Baker: gcc and clang always accepr -Wno-*, hence check for the original warning, then set the no-* flag | dnl Dylan Baker: gcc and clang always accepr -Wno-*, hence check for the original warning, then set the no-* flag | ||||
| AX_CHECK_COMPILE_FLAG([-Wmissing-field-initializers], [CFLAGS="$CFLAGS -Wno-missing-field-initializers"]) | AX_CHECK_COMPILE_FLAG([-Wmissing-field-initializers], [CFLAGS="$CFLAGS -Wno-missing-field-initializers"]) |
+ 1
- 0
meson.build
View File
| c_args = [] | c_args = [] | ||||
| foreach a : ['-Werror=implicit-function-declaration', | foreach a : ['-Werror=implicit-function-declaration', | ||||
| '-Werror=missing-prototypes', '-Werror=return-type', | '-Werror=missing-prototypes', '-Werror=return-type', | ||||
| '-Werror=incompatible-pointer-types', | |||||
| '-fno-math-errno', | '-fno-math-errno', | ||||
| '-fno-trapping-math', '-Qunused-arguments'] | '-fno-trapping-math', '-Qunused-arguments'] | ||||
| if cc.has_argument(a) | if cc.has_argument(a) |
Loading…