Browse Source

radv/gfx10: implement a bug workaround for GE_PC_ALLOC

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
tags/19.2-branchpoint
Samuel Pitoiset 6 years ago
parent
commit
e041a74588
2 changed files with 13 additions and 17 deletions
  1. 0
    17
      src/amd/vulkan/radv_pipeline.c
  2. 13
    0
      src/amd/vulkan/si_cmd_buffer.c

+ 0
- 17
src/amd/vulkan/radv_pipeline.c View File

@@ -3456,18 +3456,6 @@ radv_pipeline_generate_vgt_gs_mode(struct radeon_cmdbuf *ctx_cs,
radeon_set_context_reg(ctx_cs, R_028A40_VGT_GS_MODE, vgt_gs_mode);
}

static void
gfx10_set_ge_pc_alloc(struct radeon_cmdbuf *ctx_cs,
struct radv_pipeline *pipeline,
bool culling)
{
struct radeon_info *info = &pipeline->device->physical_device->rad_info;

radeon_set_uconfig_reg(ctx_cs, R_030980_GE_PC_ALLOC,
S_030980_OVERSUB_EN(1) |
S_030980_NUM_PC_LINES((culling ? 256 : 128) * info->max_se - 1));
}

static void
radv_pipeline_generate_hw_vs(struct radeon_cmdbuf *ctx_cs,
struct radeon_cmdbuf *cs,
@@ -3534,9 +3522,6 @@ radv_pipeline_generate_hw_vs(struct radeon_cmdbuf *ctx_cs,
if (pipeline->device->physical_device->rad_info.chip_class <= GFX8)
radeon_set_context_reg(ctx_cs, R_028AB4_VGT_REUSE_OFF,
outinfo->writes_viewport_index);

if (pipeline->device->physical_device->rad_info.chip_class >= GFX10)
gfx10_set_ge_pc_alloc(ctx_cs, pipeline, false);
}

static void
@@ -3699,8 +3684,6 @@ radv_pipeline_generate_hw_ngg(struct radeon_cmdbuf *ctx_cs,
S_03096C_PRIM_GRP_SIZE(ngg_state->max_gsprims) |
S_03096C_VERT_GRP_SIZE(ngg_state->hw_max_esverts) |
S_03096C_BREAK_WAVE_AT_EOI(break_wave_at_eoi));

gfx10_set_ge_pc_alloc(ctx_cs, pipeline, false);
}

static void

+ 13
- 0
src/amd/vulkan/si_cmd_buffer.c View File

@@ -382,6 +382,19 @@ si_emit_graphics(struct radv_physical_device *physical_device,
S_00B0C0_SOFT_GROUPING_EN(1) |
S_00B0C0_NUMBER_OF_REQUESTS_PER_CU(4 - 1));
radeon_set_sh_reg(cs, R_00B1C0_SPI_SHADER_REQ_CTRL_VS, 0);

if (physical_device->rad_info.family == CHIP_NAVI10 ||
physical_device->rad_info.family == CHIP_NAVI12 ||
physical_device->rad_info.family == CHIP_NAVI14) {
/* SQ_NON_EVENT must be emitted before GE_PC_ALLOC is written. */
radeon_emit(cs, PKT3(PKT3_EVENT_WRITE, 0, 0));
radeon_emit(cs, EVENT_TYPE(V_028A90_SQ_NON_EVENT) | EVENT_INDEX(0));
}

/* TODO: For culling, replace 128 with 256. */
radeon_set_uconfig_reg(cs, R_030980_GE_PC_ALLOC,
S_030980_OVERSUB_EN(1) |
S_030980_NUM_PC_LINES(128 * physical_device->rad_info.max_se - 1));
}

if (physical_device->rad_info.chip_class >= GFX8) {

Loading…
Cancel
Save