Browse Source

radv: fix a potential crash if attachments allocation failed

Also, it's useless to set the error code twice. Though, we
should probably skip the next commands when the command buffer
is considered invalid.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
tags/17.3-branchpoint
Samuel Pitoiset 8 years ago
parent
commit
8e8c7c6703
1 changed files with 2 additions and 1 deletions
  1. 2
    1
      src/amd/vulkan/radv_cmd_buffer.c

+ 2
- 1
src/amd/vulkan/radv_cmd_buffer.c View File

@@ -2771,9 +2771,10 @@ void radv_CmdBeginRenderPass(
cmd_buffer->state.framebuffer = framebuffer;
cmd_buffer->state.pass = pass;
cmd_buffer->state.render_area = pRenderPassBegin->renderArea;

result = radv_cmd_state_setup_attachments(cmd_buffer, pass, pRenderPassBegin);
if (result != VK_SUCCESS)
cmd_buffer->record_result = result;
return;

radv_cmd_buffer_set_subpass(cmd_buffer, pass->subpasses, true);
assert(cmd_buffer->cs->cdw <= cdw_max);

Loading…
Cancel
Save