Browse Source

meson: add -Werror=empty-body to disallow `if(x);`

This would have prevented a bug in MR 2058 [1]; with that MR fixed,
nothing else uses empty-body blocks, so let's just forbid them altogether.

[1] https://gitlab.freedesktop.org/mesa/mesa/merge_requests/2058#note_237880

Signed-off-by: Eric Engestrom <eric.engestrom@intel.com>
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
Reviewed-by: Kristian H. Kristensen <hoegsberg@google.com>
tags/19.3-branchpoint
Eric Engestrom 7 years ago
parent
commit
8d43e2b2de
1 changed files with 2 additions and 0 deletions
  1. 2
    0
      meson.build

+ 2
- 0
meson.build View File

@@ -939,6 +939,7 @@ else
'-Werror=implicit-function-declaration',
'-Werror=missing-prototypes',
'-Werror=return-type',
'-Werror=empty-body',
'-Werror=incompatible-pointer-types',
'-Wno-missing-field-initializers',
'-Wno-format-truncation',
@@ -958,6 +959,7 @@ else

_trial = [
'-Werror=return-type',
'-Werror=empty-body',
'-Wno-non-virtual-dtor',
'-Wno-missing-field-initializers',
'-Wno-format-truncation',

Loading…
Cancel
Save