Without this, I get the following error when building the tests with autotools on i686: ---8<--- src/intel/common/gen_clflush.h: In function ‘gen_clflush_range’: src/intel/common/gen_clflush.h:37:7: warning: implicit declaration of function ‘__builtin_ia32_clflush’; did you mean ‘__builtin_ia32_pause’? [-Wimplicit-function-declaration] __builtin_ia32_clflush(p); ^~~~~~~~~~~~~~~~~~~~~~ __builtin_ia32_pause src/intel/common/gen_clflush.h: In function ‘gen_flush_range’: src/intel/common/gen_clflush.h:45:4: warning: implicit declaration of function ‘__builtin_ia32_mfence’; did you mean ‘__builtin_ia32_fnclex’? [-Wimplicit-function-declaration] __builtin_ia32_mfence(); ^~~~~~~~~~~~~~~~~~~~~ __builtin_ia32_fnclex ---8<--- The erros are generated for each of these files: - mesa/src/intel/vulkan/tests/state_pool_no_free.c - mesa/src/intel/vulkan/tests/state_pool.c - mesa/src/intel/vulkan/tests/block_pool_no_free.c - mesa/src/intel/vulkan/tests/state_pool_free_list_only.c This is obviously because gen_clflush.h contains code that uses intrinsics that are only available with SSE3. Since the driver already uses SSE3, it seems reasonable to add this to the tests as well. Signed-off-by: Erik Faye-Lund <erik.faye-lund@collabora.com> Reviewed-by: Jordan Justen <jordan.l.justen@intel.com> Acked-by: Eric Engeström <eric@engestrom.ch>tags/19.0-branchpoint
@@ -262,15 +262,19 @@ VULKAN_TEST_LDADD = \ | |||
check_PROGRAMS += $(VULKAN_TESTS) | |||
TESTS += $(VULKAN_TESTS) | |||
vulkan_tests_block_pool_no_free_CFLAGS = $(VULKAN_CFLAGS) | |||
vulkan_tests_block_pool_no_free_CPPFLAGS = $(VULKAN_CPPFLAGS) | |||
vulkan_tests_block_pool_no_free_LDADD = $(VULKAN_TEST_LDADD) | |||
vulkan_tests_state_pool_no_free_CFLAGS = $(VULKAN_CFLAGS) | |||
vulkan_tests_state_pool_no_free_CPPFLAGS = $(VULKAN_CPPFLAGS) | |||
vulkan_tests_state_pool_no_free_LDADD = $(VULKAN_TEST_LDADD) | |||
vulkan_tests_state_pool_free_list_only_CFLAGS = $(VULKAN_CFLAGS) | |||
vulkan_tests_state_pool_free_list_only_CPPFLAGS = $(VULKAN_CPPFLAGS) | |||
vulkan_tests_state_pool_free_list_only_LDADD = $(VULKAN_TEST_LDADD) | |||
vulkan_tests_state_pool_CFLAGS = $(VULKAN_CFLAGS) | |||
vulkan_tests_state_pool_CPPFLAGS = $(VULKAN_CPPFLAGS) | |||
vulkan_tests_state_pool_LDADD = $(VULKAN_TEST_LDADD) | |||