This is a bug in the app, but I'd rather avoid hanging the GPU, esp if someone is running in validation and it takes out their development environment. v2: get it right, reverse the polarity. Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Cc: <mesa-stable@lists.freedesktop.org> Signed-off-by: Dave Airlie <airlied@redhat.com>tags/17.3-branchpoint
@@ -382,6 +382,11 @@ void radv_CmdResolveImage( | |||
radv_meta_save_graphics_reset_vport_scissor_novertex(&saved_state, cmd_buffer); | |||
assert(src_image->info.samples > 1); | |||
if (src_image->info.samples <= 1) { | |||
/* this causes GPU hangs if we get past here */ | |||
fprintf(stderr, "radv: Illegal resolve operation (src not multisampled), will hang GPU."); | |||
return; | |||
} | |||
assert(dest_image->info.samples == 1); | |||
if (src_image->info.samples >= 16) { |